Support arbitrary inflow at open boundary conditions (ft. psc_shock)#396
Open
JamesMcClung wants to merge 16 commits intopsc-code:mainfrom
Open
Support arbitrary inflow at open boundary conditions (ft. psc_shock)#396JamesMcClung wants to merge 16 commits intopsc-code:mainfrom
psc_shock)#396JamesMcClung wants to merge 16 commits intopsc-code:mainfrom
Conversation
Collaborator
Author
|
I can make |
I think... this warrants a double check
JamesMcClung
force-pushed
the
pr/arbitrary-inflow
branch
from
f8ba94e to
5761984
Compare
Collaborator
Author
|
One drawback to the approach taken in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new public field to
BndFields_,radiation, which is used as a callback to sample inflowing S and P waves. For demonstration purposes, this PR also includes changes to thepsc_shockcase that make use of the new field.My personal dream is to make BndFields itself polymorphic, which would enable doing away with these public fields.